fix: Enable rslib sideEffects on react-spring #3321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the rslib migration, the mui-bottom-sheet component would not work anymore due to `.willAdvance is not a function` error This is due to library's side effects that are erased by the tree shaking mechanism To prevent that we change the rsbuild configuration to handle those side effects More info: pmndrs/react-spring#1078
BundleMonFiles updated (3)
Unchanged files (18)
Total files change +232B 0% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
Merkur39
approved these changes
Feb 18, 2025
zatteo
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the rslib migration, the mui-bottom-sheet component would not work anymore due to
.willAdvance is not a functionerrorThis is due to library's side effects that are erased by the tree shaking mechanism
To prevent that we change the rsbuild configuration to handle those side effects
More info: pmndrs/react-spring#1078