Skip to content

fix(OO): The edit button must be displayed for OO shares with write access #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 3, 2025
Merged

fix(OO): The edit button must be displayed for OO shares with write access #3315

merged 4 commits into from
Feb 3, 2025

Conversation

Merkur39
Copy link
Contributor

No description provided.

@bundlemon BundleMon
Copy link

bundlemon bot commented Jan 30, 2025 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ public/drive.(hash).js
 2.09MB (+130B +0.01%) -
✅ intents/drive.(hash).js
 86.75KB (+123B +0.14%) -
✅ app/drive.(hash).js
 161.45KB (+121B +0.07%) -
Unchanged files (15)
Status Path Size Limits
✅ vendors/drive.(hash).js
 2.32MB -
✅ public/pdf.worker.entry.(hash).worker.js
 345.35KB -
✅ services/qualificationMigration/drive.js
 283.77KB -
✅ services/dacc/drive.js
 263.37KB -
✅ public/cozy-client-js.js
 159.28KB -
✅ public/drive.(hash).min.css
 39.54KB -
✅ onlyOffice/slide.pptx
 24.83KB -
✅ app-drive.(hash).min.css
 10.17KB -
✅ intents-drive.(hash).min.css
 8.44KB -
✅ onlyOffice/text.docx
 5.85KB -
✅ onlyOffice/spreadsheet.xlsx
 5.02KB -
✅ manifest.webapp
 1.92KB -
✅ index.html
 598B -
✅ intents/index.html
 508B -
✅ manifest.json
 185B -

Total files change +374B +0.01%

Groups updated (3)
Status Path Size Limits
✅ public/**
 2.63MB (+130B 0%) -
✅ intents/**
 87.25KB (+123B +0.14%) -
✅ app/**
 161.45KB (+121B +0.07%) -
Unchanged groups (4)
Status Path Size Limits
✅ vendors/**
 2.32MB -
✅ services/**
 547.14KB -
✅ onlyOffice/**
 35.7KB -
✅ img/**
 5.85KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

JF-Cozy
JF-Cozy approved these changes Jan 30, 2025
View reviewed changes
@Merkur39
fix(OO): Hide OpenSharingLinkButton to Cozy to Cozy sharing
f3d0511 
And `SharingBannerPlugin`
@Merkur39
fix(OO): Hide tooltip on Edit button
f0eda8a 
Being in the public view, queries are not allowed,
so the tooltip cannot save its hidden state when
the user chooses it.
@Merkur39 Merkur39 merged commit 21f177b into master Feb 3, 2025
4 checks passed
@Merkur39 Merkur39 deleted the fix/front-1313 branch February 3, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JF-Cozy JF-Cozy JF-Cozy approved these changes

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Merkur39 @JF-Cozy