Remove hammerjs #3295
Merged
Remove hammerjs #3295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fbbc5a to
468788d
Compare
BundleMonFiles updated (3)
Unchanged files (15)
Total files change -15.36KB -0.26% Groups updated (3)
Unchanged groups (4)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
commented
Jan 16, 2025
| // remove event when it's the checkbox or the more button | ||
| if ( | ||
| parentDiv.className.indexOf(styles['fil-content-file-select']) !== -1 || | ||
| parentDiv.className.indexOf(styles['fil-content-file-action']) !== -1 |
There was a problem hiding this comment.
This condition is not necessary anymore. These buttons does not trigger an event at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the hammerjs dep which was used only for one behavior. Not necessary to add two packages which what it implies for this behavior that can easily be managed manually.
To do :