feat: Mutualize queries by id in store #3419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0148305 to
57a9a94
Compare
We had 3 different queries to do the same thing: query a io.cozy.files by its id. Typically for a directory `abc`, we had 3 queries named: - `io.cozy.files/abc` - `onlyfolder-abc` - `folder-abc` The only specialization was for the `folder-abc` that was including `parent` and `encryption`, but it does not seem used anymore. This is useless and hurt performances: as we duplicate such queries, they are kept in the store and reevaluated independently even though the id and the results are the same. It also takes memory for nothing. Thus, let's mutualize.
57a9a94 to
c3b621d
Compare
BundleMonFiles updated (3)
Unchanged files (18)
Total files change -193B 0% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
rezk2ll
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 3 different queries to do the same thing: query a io.cozy.files by its id.
Typically for a directory
abc, we had 3 queries named:io.cozy.files/abconlyfolder-abcfolder-abcThe only specialization was for the
folder-abcthat was includingparentandencryption, but it does not seem used anymore.This is useless and hurt performances: as we duplicate such queries, they are kept in the store and reevaluated independently even though the id and the results are the same. It also takes memory for nothing. Thus, let's mutualize.