Skip to content

Right click rework #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 19, 2025
Merged

Right click rework #3406

merged 8 commits into from
Jun 19, 2025

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Jun 19, 2025 •
edited
Loading

The goal here is to use only one provider, instead of one by right-clickable elements. Besides we don't add a div holding the onContextMenu event anymore, we adding it on the child of the wrappers.

JF-Cozy added 3 commits June 19, 2025 14:31
@JF-Cozy
feat: Add ClickAway on AddMenu to be able to close it with right click
f1dda36 
- span is needed because the first child of ClickAway has to hold the ref.
- onMouseUp is the only event working with right click
@JF-Cozy
feat: Remove previous right click behavior
1021207
@JF-Cozy
refactor(File): Add props spread
1d9cefe 
to be able to use right-click wrapper
@bundlemon BundleMon
Copy link

bundlemon bot commented Jun 19, 2025 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ static/js/main.(hash).js
 117.81KB (+251B +0.21%) -
✅ static/js/cozy.(hash).js
 847.95KB (+105B +0.01%) -
✅ public/static/js/public.(hash).js
 85.79KB (-108B -0.12%) -
Unchanged files (18)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 967.44KB -
✅ public/static/js/(chunkId).(hash).js
 856.47KB -
✅ public/static/js/cozy.(hash).js
 713.66KB -
✅ (hash).js
 337.62KB -
✅ public/(hash).js
 337.62KB -
✅ services/qualificationMigration.js
 282.6KB -
✅ services/dacc.js
 264.84KB -
✅ public/static/js/lib-react.(hash).js
 39.37KB -
✅ static/js/lib-react.(hash).js
 39.37KB -
✅ public/static/css/cozy.(hash).css
 33.73KB -
✅ static/css/cozy.(hash).css
 33.73KB -
✅ public/static/js/lib-router.(hash).js
 22.05KB -
✅ static/js/lib-router.(hash).js
 22.05KB -
✅ static/css/main.(hash).css
 16.28KB -
✅ public/static/css/public.(hash).css
 5.63KB -
✅ manifest.webapp
 1.89KB -
✅ index.html
 689B -
✅ assets/manifest.json
 185B -

Total files change +250B 0%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 6.44MB (+388B +0.01%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.15MB -
✅ **/*.css
 128.42KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

zatteo
zatteo reviewed Jun 19, 2025
View reviewed changes
JF-Cozy added 2 commits June 19, 2025 17:21
@JF-Cozy
feat: Modify right click component to use different approach
154dfa1 
The goal here is to use only one provider, instead of one by
right-clickable elements. Besides we don't add a div holding the
onContextMenu event anymore, we adding it on the child of the
wrappers.
@JF-Cozy
feat: Use new right click behavior
e1b20c4
@JF-Cozy JF-Cozy merged commit 64de4bd into master Jun 19, 2025
4 checks passed
@JF-Cozy JF-Cozy deleted the feat/rightClick branch June 19, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatteo zatteo zatteo approved these changes

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

@lenhanphung lenhanphung Awaiting requested review from lenhanphung lenhanphung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JF-Cozy @zatteo