Skip to content

Display AddMenu Fab in tablet #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

Display AddMenu Fab in tablet #3402

merged 3 commits into from
Jun 18, 2025

Conversation

zatteo
Copy link
Member

@zatteo zatteo commented Jun 16, 2025 •
edited
Loading

Prerequisite : cozy/cozy-ui#2811

@bundlemon BundleMon
Copy link

bundlemon bot commented Jun 16, 2025 •
edited
Loading

BundleMon

Files updated (4)
Status Path Size Limits
✅ public/static/js/public.(hash).js
 85.88KB (+36B +0.04%) -
✅ static/js/cozy.(hash).js
 847.84KB (+29B 0%) -
✅ static/js/main.(hash).js
 117.57KB (+18B +0.01%) -
✅ public/static/js/cozy.(hash).js
 713.66KB (+17B 0%) -
Unchanged files (17)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 967.44KB -
✅ public/static/js/(chunkId).(hash).js
 856.47KB -
✅ (hash).js
 337.62KB -
✅ public/(hash).js
 337.62KB -
✅ services/qualificationMigration.js
 282.6KB -
✅ services/dacc.js
 264.84KB -
✅ public/static/js/lib-react.(hash).js
 39.37KB -
✅ static/js/lib-react.(hash).js
 39.37KB -
✅ public/static/css/cozy.(hash).css
 33.73KB -
✅ static/css/cozy.(hash).css
 33.73KB -
✅ public/static/js/lib-router.(hash).js
 22.05KB -
✅ static/js/lib-router.(hash).js
 22.05KB -
✅ static/css/main.(hash).css
 16.28KB -
✅ public/static/css/public.(hash).css
 5.63KB -
✅ manifest.webapp
 1.89KB -
✅ index.html
 689B -
✅ assets/manifest.json
 185B -

Total files change +101B 0%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 6.44MB (+122B 0%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.15MB -
✅ **/*.css
 128.42KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

JF-Cozy
JF-Cozy approved these changes Jun 16, 2025
View reviewed changes
zatteo added 3 commits June 18, 2025 11:11
@zatteo
feat: Update cozy-ui
3ec18d4
@zatteo
fix: Display Fab that open AddMenu in tablet
eae8bbe 
- Button in sidebar to open AddMenu is displayed only when isDesktop
is true
- Fab button to open AddMenu is displayed only when isMobile is true

But this two does not overlap. So in tablet mode we had no Button and
no Fab to open AddMenu. So now we display Fab button when isDesktop
is false.
@zatteo
fix: Display correctly AddMenu in tablet
8042614 
The AddMenu was not displayed because the ref was not set to the
correct element.

I also pass to AddMenuProvider a new prop to allow to change
anchorOrigin to position AddMenu correctly when opening it from Fab
button.
@zatteo zatteo force-pushed the fix/no-add-menu-in-tablet branch from 1aa6d0b to 8042614 Compare June 18, 2025 09:14
@zatteo zatteo merged commit 55f6312 into master Jun 18, 2025
4 checks passed
@zatteo zatteo deleted the fix/no-add-menu-in-tablet branch June 18, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JF-Cozy JF-Cozy JF-Cozy approved these changes

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

@lenhanphung lenhanphung Awaiting requested review from lenhanphung lenhanphung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zatteo @JF-Cozy