Skip to content

depend on openjdk for catalina macos onwards #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

depend on openjdk for catalina macos onwards #6

merged 1 commit into from
Dec 10, 2020

Conversation

softinio
Copy link
Contributor

@softinio softinio commented Dec 6, 2020

This is to resolve following warning I got when updating coursier via homebrew on macos catalina today:

Warning: Calling depends_on :java is deprecated! Use "depends_on "openjdk@11", "depends_on "openjdk@8" or "depends_on "openjdk" instead.
Please report this issue to the coursier/formulas tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/coursier/homebrew-formulas/coursier.rb:18

Warning: Calling depends_on :java is deprecated! Use "depends_on "openjdk@11", "depends_on "openjdk@8" or "depends_on "openjdk" instead.
Please report this issue to the coursier/formulas tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/coursier/homebrew-formulas/coursier.rb:18

@joriscode
Copy link

I've tried it locally (on Catalina) and this doesn't seem to remove the warning which is relative to :java dependency keyword. However, the change looks legit to me anyway :)

@dc-avasilev
Copy link

dc-avasilev commented Dec 10, 2020 •
edited
Loading 

 OS: 64bit Mac OS X 10.15.7 19H15
 Kernel: x86_64 Darwin 19.6.0
 Uptime: 4d 1h 26m
 Packages: 612
 Shell: zsh 5.8
 Resolution: 3072x1920
 DE: Aqua
 WM: Quartz Compositor
 WM Theme: Graphite (Dark)
 Disk: 12G / 1.1T (2%)
 CPU: Intel Core i9-9880H @ 2.30GHz
 GPU: Intel UHD Graphics 630 / AMD Radeon Pro 5500M
 RAM: 8749MiB / 16384MiB

checked it, same warning is disappeared, need merge

@dc-avasilev dc-avasilev mentioned this pull request Dec 10, 2020
Closed
alexarchambault
alexarchambault approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexarchambault alexarchambault merged commit 06441f0 into coursier:master Dec 10, 2020
@alexarchambault alexarchambault mentioned this pull request Dec 10, 2020
Merged
@softinio softinio deleted the patch-1 branch December 12, 2020 21:56
@toshihidetagami toshihidetagami mentioned this pull request Jan 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

+1 more reviewer

@dc-avasilev dc-avasilev dc-avasilev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@softinio @joriscode @dc-avasilev @alexarchambault