Build things with JDK 17, but preserve Java 8 compat anyway #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2489b70 to
543454c
Compare
|
Scala 2: in case that is useful. Not ported to Scala 3 (yet?), but maybe because there was no feedback. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, publishing fails because:
0.12.xpublish tasks require JDK >= 11--require 8to javac and scalacsun.misc.Signalstuff), and neither javac nor scalac accept options to enable access to it alongside--release 8(javac doesn't accept--add-exports jdk.unsupported/sun.misc=ALL-UNNAMEDalongside--release, and scalac doesn't allow passing such an option altogether anyway, see Support alternative JVM system images (via-system, like javac) scala/scala#10801)To work around that, this PR:
--release 8to scalaccache-utilmodule-source 8 -target 8 -bootclasspath some-jdk-8/jre/lib/rt.jarto javac in order to allow access to unsupported JDK APIs