Skip to content

Stop using FileOutputStream #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Stop using FileOutputStream #3124

wants to merge 2 commits into from

Conversation

alexarchambault
Copy link
Member

No description provided.

@alexarchambault alexarchambault force-pushed the nio-file-streams branch 2 times, most recently from 3ba543e to c59cad9 Compare October 28, 2024 14:58
@alexarchambault
Copy link
Member Author

Might put these changes on hold, just got the following error in this job:

[2164/2165] cli-tests[2.12.20].test.test
[2164] -------------------------------- Running Tests --------------------------------
[2163] Resolution error: Error downloading org.scalameta:trees_2.12:1.7.0
[2163]   not found: C:\Users\runneradmin\.ivy2\local\org.scalameta\trees_2.12\1.7.0\ivys\ivy.xml
[2163]   download error: Caught java.nio.file.AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock) while downloading https://repo1.maven.org/maven2/org/scalameta/trees_2.12/1.7.0/trees_2.12-1.7.0.pom
[2163] Error downloading org.scalameta:transversers_2.12:1.7.0
[2163]   not found: C:\Users\runneradmin\.ivy2\local\org.scalameta\transversers_2.12\1.7.0\ivys\ivy.xml
[2163]   download error: Caught java.nio.file.AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock) while downloading https://repo1.maven.org/maven2/org/scalameta/transversers_2.12/1.7.0/transversers_2.12-1.7.0.pom
[2163] Error downloading org.scalameta:inputs_2.12:1.7.0
[2163]   not found: C:\Users\runneradmin\.ivy2\local\org.scalameta\inputs_2.12\1.7.0\ivys\ivy.xml
[2163]   download error: Caught java.nio.file.AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock) while downloading https://repo1.maven.org/maven2/org/scalameta/inputs_2.12/1.7.0/inputs_2.12-1.7.0.pom
[2163] Error downloading com.geirsson:metaconfig-typesafe-config_2.12:0.4.0
[2163]   not found: C:\Users\runneradmin\.ivy2\local\com.geirsson\metaconfig-typesafe-config_2.12\0.4.0\ivys\ivy.xml
[2163]   download error: Caught java.nio.file.AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock) while downloading https://repo1.maven.org/maven2/com/geirsson/metaconfig-typesafe-config_2.12/0.4.0/metaconfig-typesafe-config_2.12-0.4.0.pom
[2163] Error downloading org.scalameta:tokens_2.12:1.7.0
[2163]   not found: C:\Users\runneradmin\.ivy2\local\org.scalameta\tokens_2.12\1.7.0\ivys\ivy.xml
[2163]   download error: Caught java.nio.file.AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock) while downloading https://repo1.maven.org/maven2/org/scalameta/tokens_2.12/1.7.0/tokens_2.12-1.7.0.pom
[2163] Error downloading com.trueaccord.scalapb:scalapb-runtime_2.12:0.6.0-pre2
[2163]   not found: C:\Users\runneradmin\.ivy2\local\com.trueaccord.scalapb\scalapb-runtime_2.12\0.6.0-pre2\ivys\ivy.xml
[2163]   download error: Caught java.nio.file.AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock) while downloading https://repo1.maven.org/maven2/com/trueaccord/scalapb/scalapb-runtime_2.12/0.6.0-pre2/scalapb-runtime_2.12-0.6.0-pre2.pom
[2163] Error downloading org.scalameta:parsers_2.12:1.7.0
[2163]   not found: C:\Users\runneradmin\.ivy2\local\org.scalameta\parsers_2.12\1.7.0\ivys\ivy.xml
[2163]   download error: Caught java.nio.file.AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock) while downloading https://repo1.maven.org/maven2/org/scalameta/parsers_2.12/1.7.0/parsers_2.12-1.7.0.pom
[2163] Error downloading org.scalameta:dialects_2.12:1.7.0
[2163]   not found: C:\Users\runneradmin\.ivy2\local\org.scalameta\dialects_2.12\1.7.0\ivys\ivy.xml
[2163]   download error: Caught java.nio.file.AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock) while downloading https://repo1.maven.org/maven2/org/scalameta/dialects_2.12/1.7.0/dialects_2.12-1.7.0.pom
[2164/2165] ================================= jvmTests --scalaVersion 2.12.20 =================================== 268s
======================================================================================================================
An unexpected error occurred
Exception in thread "main" java.lang.ClassCastException: class java.lang.Integer cannot be cast to class mill.api.Val (java.lang.Integer is in module java.base of loader 'bootstrap'; mill.api.Val is in unnamed module of loader 'app')
	at mill.api.Result$Failure.$anonfun$map$1(Result.scala:77)
	at scala.Option.map(Option.scala:242)
	at mill.api.Result$Failure.map(Result.scala:77)
	at mill.api.Result$Failure.map(Result.scala:76)
	at mill.eval.GroupEvaluator.$anonfun$evaluateGroup$3(GroupEvaluator.scala:321)
	at mill.eval.GroupEvaluator.$anonfun$evaluateGroup$3$adapted(GroupEvaluator.scala:256)
	at scala.collection.immutable.Vector.foreach(Vector.scala:2125)
	at mill.eval.GroupEvaluator.computeAll$1(GroupEvaluator.scala:256)
	at mill.eval.GroupEvaluator.evaluateGroup(GroupEvaluator.scala:334)
	at mill.eval.GroupEvaluator.$anonfun$evaluateGroupCached$1(GroupEvaluator.scala:202)
	at mill.api.Logger.withPrompt(Logger.scala:83)
	at mill.api.Logger.withPrompt$(Logger.scala:81)
	at mill.util.PrefixLogger.withPrompt(PrefixLogger.scala:7)
	at mill.eval.GroupEvaluator.evaluateGroupCached(GroupEvaluator.scala:67)
	at mill.eval.GroupEvaluator.evaluateGroupCached$(GroupEvaluator.scala:47)
	at mill.eval.EvaluatorImpl.evaluateGroupCached(EvaluatorImpl.scala:16)
	at mill.eval.EvaluatorCore.$anonfun$evaluate0$2(EvaluatorCore.scala:163)
	at scala.concurrent.impl.Promise$Transformation.run(Promise.scala:467)
	at mill.eval.ExecutionContexts$ThreadPool$$anon$1.$anonfun$run$3(ExecutionContexts.scala:69)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
	at mill.api.SystemStreams$.$anonfun$withStreams$6(SystemStreams.scala:100)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
	at mill.api.SystemStreams$.$anonfun$withStreams$5(SystemStreams.scala:99)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
	at mill.api.SystemStreams$.$anonfun$withStreams$4(SystemStreams.scala:98)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
	at scala.Console$.withErr(Console.scala:193)
	at mill.api.SystemStreams$.$anonfun$withStreams$3(SystemStreams.scala:97)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
	at scala.Console$.withOut(Console.scala:164)
	at mill.api.SystemStreams$.$anonfun$withStreams$2(SystemStreams.scala:96)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
	at scala.Console$.withIn(Console.scala:227)
	at mill.api.SystemStreams$.$anonfun$withStreams$1(SystemStreams.scala:95)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
	at mill.api.SystemStreams$.withStreams(SystemStreams.scala:94)
	at mill.eval.ExecutionContexts$ThreadPool$$anon$1.$anonfun$run$2(ExecutionContexts.scala:69)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
	at mill.eval.ExecutionContexts$ThreadPool$$anon$1.run(ExecutionContexts.scala:68)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)

Seems it's a coursier issue, then a Mill issue :/

Not sure a retry would have prevented the AccessDeniedException (C:\Users\runneradmin\AppData\Local\Coursier\cache\v1\.structure.lock), as many downloads at once seem to have run into it.

The runs that followed didn't run into that error, so it seems not to happen too often…

This was referenced Oct 29, 2024
Merged
Merged
@alexarchambault alexarchambault changed the title Stop using FileInputStream / FileOutputStream Stop using FileOutputStream Oct 29, 2024
@alexarchambault alexarchambault mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexarchambault