Skip to content

Skip directories when listing installed tools, fix #3117 #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Skip directories when listing installed tools, fix #3117 #3118

merged 1 commit into from
Nov 4, 2024

Conversation

allxiao
Copy link
Contributor

@allxiao allxiao commented Oct 25, 2024 •
edited
Loading

Fix #3117

alexarchambault
alexarchambault reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@alexarchambault alexarchambault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks fine.

I'm just wondering if a non-regression test can be added for that, under modules/install/src/test/scala, without this needing too much work…

@alexarchambault
Copy link
Member

Merging so that this makes it in the next release

@alexarchambault alexarchambault merged commit f5cc469 into coursier:main Nov 4, 2024
23 checks passed
@allxiao allxiao mentioned this pull request Dec 5, 2024
Merged
alexarchambault pushed a commit that referenced this pull request Dec 5, 2024
@allxiao
Add tests for InstallDir#list as follow up of #3118 (#3182)
dd9bf8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command error when COURSIER_INSTALL_DIR has nested directories
2 participants
@allxiao @alexarchambault