Remove argonaut-shapeless dependency from jvm module #3094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7632743 to
4d3685f
Compare
This isn't a binary compatibility isssue but a incomplete declared dependencies issue. Dropping unused dependencies should always be ok, unless you claim to provide some kind of framework that provides all that is needed, which shouldn't be the case for coursier as a library. |
tgodzik
approved these changes
Oct 13, 2024
lefou
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems it was unused.
I think dropping dependencies is supposed to break binary compatibility though 🤔 (if a library compiled with coursier
2.1.14relies on shapeless via it, and users bump coursier to2.1.15at runtime, shapeless is likely to be missing)