Back to empty user agent #2294
Merged
Back to empty user agent #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b0af9c to
f7927be
Compare
julienrf
reviewed
Dec 12, 2021
| @@ -140,6 +140,10 @@ object CacheUrl { | |||
| // handling those ourselves, so that we can update credentials upon redirection | |||
| conn0.setInstanceFollowRedirects(false) | |||
|
|
|||
| // Early in the development of coursier, I ran into some repositories (Sonatype ones?) not | |||
| // returning the same content for user agent "Java/…". | |||
| conn0.setRequestProperty("User-Agent", "") | |||
There was a problem hiding this comment.
Can we make
Suggested change
| conn0.setRequestProperty("User-Agent", "") | |
| conn0.setRequestProperty("User-Agent", "Coursier") |
As initially proposed in #2246?
There was a problem hiding this comment.
curl test says "Coursier" would work too
$ curl -H "User-Agent: Coursier" https://oss.sonatype.org/content/repositories/snapshots/org/zeromq/jeromq/0.5.3-SNAPSHOT/maven-metadata.xmlso I am happy with either.
There was a problem hiding this comment.
I think I'm going to cut a release with an empty user agent (former behavior), then one with a Coursier user agent. So that we can switch back to the other if the Coursier user agent ends up having issues too.
See discussion in coursier#2287 This reverts commit b7355f5.
f7927be to
391898b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2287.