Switch back to scala-xml 1.x #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
827e2ca to
f99b09e
Compare
ckipp01
added a commit
to ckipp01/coursier
that referenced
this pull request
Oct 14, 2022
This is a continuation or really a revert of what was done in coursier#2274. Originally this was done because Scala 2.12 was on 1.x, but that is no longer the case. You can see the discussion for this in scala/bug#12632. I'm assuming that other things like sbt that will use this will also hit on it as well if it's still on 1.x. See sbt/sbt#6997 for more details on that. This also then bumps Scala 2.12 to 2.12.17 to make sure the scala-xml is aligned there too.
ckipp01
added a commit
to ckipp01/coursier
that referenced
this pull request
Oct 14, 2022
This is a continuation or really a revert of what was done in coursier#2274. Originally this was done because Scala 2.12 was on 1.x, but that is no longer the case. You can see the discussion for this in scala/bug#12632. I'm assuming that other things like sbt that will use this will also hit on it as well if it's still on 1.x. See sbt/sbt#6997 for more details on that. This also then bumps Scala 2.12 to 2.12.17 to make sure the scala-xml is aligned there too.
alexarchambault
pushed a commit
that referenced
this pull request
Oct 18, 2022
This is a continuation or really a revert of what was done in #2274. Originally this was done because Scala 2.12 was on 1.x, but that is no longer the case. You can see the discussion for this in scala/bug#12632. I'm assuming that other things like sbt that will use this will also hit on it as well if it's still on 1.x. See sbt/sbt#6997 for more details on that. This also then bumps Scala 2.12 to 2.12.17 to make sure the scala-xml is aligned there too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2273.