Skip to content

fix: explicit termination in the post-step #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2024
Merged

fix: explicit termination in the post-step #598

merged 1 commit into from
Apr 7, 2024

Conversation

laughedelic
Copy link
Member

Fixes #580 (hopefully)

@laughedelic
Copy link
Member Author

Compared to the last CI run where the post-step was hanging for 2 minutes after all saves, CI on this branch looks promising with 8-15s in the post-step.

@laughedelic laughedelic marked this pull request as ready for review April 7, 2024 23:03
@laughedelic laughedelic self-assigned this Apr 7, 2024
alexarchambault
alexarchambault approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @laughedelic!

@alexarchambault alexarchambault merged commit 1f647d4 into coursier:main Apr 7, 2024
@laughedelic laughedelic deleted the fix/dangling-post-save branch April 7, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees

@laughedelic laughedelic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post run action takes too much time occasionally
2 participants
@laughedelic @alexarchambault