privval: improve accept connection retry logic #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Mar 3, 2023
| @@ -193,11 +199,6 @@ func (sl *SignerListenerEndpoint) serviceLoop() { | |||
| return | |||
| } | |||
| } | |||
|
|
|||
| select { | |||
| case sl.connectRequestCh <- struct{}{}: | |||
There was a problem hiding this comment.
this always followed default case since a single goroutine cannot read-and-write to the same unbuffered channel. So this select had no affect.
3 tasks
github-merge-queue bot
pushed a commit
to cometbft/cometbft
that referenced
this pull request
Jan 30, 2024
Before the change, we'd error after just 1 attempt of accepting a connection. Co-authored by: @corverroos Closes #452 Port of corverroos/tendermint#1 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
mergify bot
pushed a commit
to cometbft/cometbft
that referenced
this pull request
Jan 30, 2024
Before the change, we'd error after just 1 attempt of accepting a connection. Co-authored by: @corverroos Closes #452 Port of corverroos/tendermint#1 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit a8991d6)
mergify bot
pushed a commit
to cometbft/cometbft
that referenced
this pull request
Jan 30, 2024
Before the change, we'd error after just 1 attempt of accepting a connection. Co-authored by: @corverroos Closes #452 Port of corverroos/tendermint#1 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit a8991d6) # Conflicts: # .changelog/v0.38.3/bug-fixes/2047-privval-retry-accepting-conn.md
mergify bot
pushed a commit
to cometbft/cometbft
that referenced
this pull request
Aug 30, 2024
Before the change, we'd error after just 1 attempt of accepting a connection. Co-authored by: @corverroos Closes #452 Port of corverroos/tendermint#1 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit a8991d6) # Conflicts: # .changelog/v0.37.5/bug-fixes/2047-privval-retry-accepting-conn.md
3 tasks
mergify bot
added a commit
to cometbft/cometbft
that referenced
this pull request
Aug 30, 2024
…#3899) Before the change, we'd error after just 1 attempt of accepting a connection. Co-authored by: @corverroos Closes #452 Port of corverroos/tendermint#1 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #2047 done by [Mergify](https://mergify.com). --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes serviceloop logic to retry attempting to accept connections only on error.
Closes: tendermint#10009