Improve cbindgen by regenerating bindings only when necessary #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6991ad2 to
ca79d40
Compare
This allows us to regenerate the bindings only when necessary
ca79d40 to
dc69c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new v0.25.0 release of cbindgen adds a
--depfileoption, that CMake can use to determine when to re-run cbindgen.This feature requires the
DEPFILEparameter ofadd_custom_commandand is available on most generators by now.If CMake is too old, or the Generator does not support
DEPFILE, then we fallback to always rerunning cbindgen as before.