-
-
Notifications
You must be signed in to change notification settings - Fork 415
feat: added detection for LaTeX injection #4206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Quantitative test results for language: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice addition!
Your regex is too wide, it is matching, for example:
I suggest to match only specitifc latex commands, which we consider dangerous, for example |
Should not be merged yet. |
Already merged, revert not possible without creating another PR. Will create another PR with suggested changes. |
Thanks. |
FYI @fzipi. |
Ugh. |
@Xhoenix You promised to send a PR, do you have time for it or should we handle it? |
I wanted to implement the changes, but decided not due to the discussion in #4210. Let's get that sorted out. |
It MUST be changed somehow, no matter what, we cannot match strings like |
I'll try to modify #4210. |
For what is worth, we are reverting this one then until someone comes with a fix. |
Reference: Link