feat: 933120 change from capture and double pmf to regex
#4138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📊 Quantitative test results for language: |
theseion
requested changes
May 30, 2025
tests/regression/tests/REQUEST-933-APPLICATION-ATTACK-PHP/933120.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
…20.yaml Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
|
all done i hope @theseion , thanks |
theseion
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the rule 933120 from the current method:
to a single regex. This removes the need for an inefficient capture.
It gives us performance gaisns of between 42 and 109 times (99th percentile) for the Rust regex crate. It was causing latencies of between 15-35ms when running all the tests. The difference won't be as pronounced with PCRE2 but other regex engines may see similar benefits.