Skip to content

feat: added MongoDB operators #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 27, 2025
Merged

Conversation

Xhoenix
Copy link
Member

@Xhoenix Xhoenix commented Jun 19, 2025

Added MongoDB Query and Projection Operators.

There are also Update and Aggregation Operators, any suggestions about these are welcome.

Copy link
Contributor

github-actions bot commented Jun 19, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@Xhoenix Xhoenix requested a review from a team June 20, 2025 08:12
@Xhoenix Xhoenix added the release:new-detection In this PR we introduce a new detection label Jun 20, 2025
@fzipi
Copy link
Member

fzipi commented Jun 20, 2025

I think it makes sense to add both set of commands. We are already using $ to prefix the actual command name, so the FP rate should be mostly non-existant.

One thing you can do is get the commands from the markdown page (e.g. https://www.mongodb.com/docs/manual/reference/operator/update.md) and filter the names. A simple command to perform this is:

curl https://www.mongodb.com/docs/manual/reference/operator/update.md | grep -o '\[\`$.*\`\]' | cut -f2 -d\`

You'll need some cleanup afterwards, but you get the idea. 😄

@Xhoenix
Copy link
Member Author

Xhoenix commented Jun 27, 2025

@fzipi need your approval.

@fzipi
Copy link
Member

fzipi commented Jun 27, 2025

Looks good. Can you please add a description on the .ra stating there these commands are coming from? I would like to see the urls you checked (e.g. https://www.mongodb.com/docs/manual/reference/operator/update.md) listed so anyone in the future can update this list. If you want to include the curl command it is file also.

Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@fzipi fzipi added this pull request to the merge queue Jun 27, 2025
Merged via the queue into coreruleset:main with commit fafed56 Jun 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:new-detection In this PR we introduce a new detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants