-
-
Notifications
You must be signed in to change notification settings - Fork 415
feat: added zmodload and sudo-rs #4143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Quantitative test results for language: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more (for a new PR maybe):
bin/builtin
bin/done
bin/endif
bin/endsw
bin/esac
bin/fi
bin/foreach
bin/function
bin/history
bin/hup
bin/repeat
bin/set
bin/setenv
Some others are builtins, but also exist as separated binaries so we cannot remove:
bin/echo
bin/local
bin/printenv
And maybe we also want to add sudo-rs
? reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add sudo-rs
also? Does it live in bin/
, right?
Looks like |
Why did you remove the builtins? I just realised that |
Sorry if I'm mistaken, but doesn't adding pointless entries, that doesn't exist in real systems, bad for performance? Also, not sure most entries without the |
In general, yes, but they do exist. If you manage to execute a shell, you can call |
@Xhoenix can you fix the conflict so we merge this one? thanks! |
Everything looks good. @theseion waiting for approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
@theseion need your approval. |
No description provided.