fix: create a stricter sibling to 932370 and move at to PL-2 (932370 PL-1, 932371 PL-2)
#4015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📊 Quantitative test results for language: |
|
@EsadCetiner Makes sense to me. Can you resolve the conflicts so we move on? |
|
@fzipi ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes false positive with newline characters preceding the Windows
atcommand (Not UNIX) by creating a stricter sibling at PL-2 to detectatcommands. The only other way to fix this false positive is by removing newline characters from the evasion prefix, however newline characters have been used for evasions in the past.closes #3953