Skip to content

feat: detect compressed database dumps #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EsadCetiner
Copy link
Member

Adds support for blocking compressed database dumps by adding .sql.archive-extension.
I used this list https://www.ncsc.admin.ch/dam/ncsc/de/dokumente/infos-it-spezialisten/govcert/govcert-ncsc_blocked-filetypes.txt.download.txt/govcert-ncsc_blocked-filetypes.txt for all of the archive filetypes, and then removed file formats that you typically won't use for this use case (For example there were some extensions for Unreal Engine, deb and rpm packages). I've left the niche archive types just in case somebody does use them.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

Copy link
Contributor

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Could you add at least one positive test?

@theseion theseion added the release:new-detection In this PR we introduce a new detection label Apr 5, 2025
@theseion theseion added this pull request to the merge queue Apr 5, 2025
Merged via the queue into coreruleset:main with commit 8ae20e3 Apr 5, 2025
6 checks passed
@EsadCetiner EsadCetiner deleted the feat-detect-compressed-database-dumps branch April 5, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:new-detection In this PR we introduce a new detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants