Skip to content

feat: refresh restricted-upload.data #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

feat: refresh restricted-upload.data #4046

merged 1 commit into from
Mar 28, 2025

Conversation

S0obi
Copy link
Contributor

@S0obi S0obi commented Mar 23, 2025 •
edited
Loading

Dear coreruleset community,

After browsing the list of issues, I found this one that I can help with and familiarize myself with the contribution process.

I will first propose to refresh this data file by fixing and executing again the legacy script that I downloaded from previous version of this repository. I sorted the list alphabetically, in order to help the reviewer, here is the list of new keywords and the ones removed :

Added ✅

  • .boto
  • .envrc
  • .fish
  • .netrc
  • .npmrc
  • .selected_editor
  • .svnignore
  • .tmux.conf
  • .vscode
  • .yarnrc
  • .zshenv
  • BlockCypher.log
  • cloud-config.yml
  • compose.yaml
  • compose.yml
  • fish_variables
  • ldap-authentication-report.csv
  • secrets.json
  • sendgrid.env
  • user_secrets.yml

Removed ❌

  • .docker (because it's now a folder)

The second step will be to port this script in crs-toolchain by addressing issue coreruleset/crs-toolchain/issues/181

Refs: #3916

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 23, 2025 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@S0obi S0obi mentioned this pull request Mar 23, 2025
Closed
@theseion
Copy link
Contributor

Thanks @S0obi, much appreciated! I don't think the list should loose any entries, unless there's an explicit reason. That would mean, porting the missing entries to lfi-os-files.data. There's currently an open PR for modifying that file (#4045), so it probably makes sense to wait for the merge of that PR.

@theseion theseion added the 🚀 enhancement New feature or request label Mar 23, 2025
@S0obi S0obi force-pushed the feature/refresh-restricted-upload.data branch from 9884ac2 to 3181976 Compare March 26, 2025 21:02
@S0obi S0obi force-pushed the feature/refresh-restricted-upload.data branch from 3181976 to 1d22fe0 Compare March 26, 2025 21:06
@S0obi
Copy link
Contributor Author

S0obi commented Mar 26, 2025 •
edited
Loading

@theseion I rebased the branch on main after #4045 was merged. I also restored previously removed entries and only remove ".docker" that is now a folder in rules/restricted-files.data.

@theseion theseion requested a review from EsadCetiner March 27, 2025 17:33
@theseion
Copy link
Contributor

Thanks. I'd like @EsadCetiner to also look through the changes.

@theseion theseion added this pull request to the merge queue Mar 28, 2025
Merged via the queue into coreruleset:main with commit fdef116 Mar 28, 2025
8 checks passed
@theseion
Copy link
Contributor

Thank you for your very first contribution @S0obi! I hope it is just the first of many more :)

@fzipi fzipi mentioned this pull request Apr 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

@EsadCetiner EsadCetiner EsadCetiner approved these changes

Assignees
No one assigned
Labels
release:fix 🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@S0obi @theseion @EsadCetiner @fzipi