Skip to content

chore: quantitative diff #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 18, 2024
Merged

chore: quantitative diff #3927

merged 13 commits into from
Nov 18, 2024

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Nov 4, 2024 •
edited
Loading

  • Quantitative test is not going to fail even if more false positives are detected
  • A comment is added to the PR showing the results of the testing
  • Quantitative test is executed only if there are changes under rules/ folder

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@M4tteoP
Copy link
Member Author

M4tteoP commented Nov 4, 2024 •
edited
Loading

Example of no changes:
📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

Example of diffs:
⚠️ Quantitative testing detected new false positives
📝 Total false positives: 408 -> 10407

Diff details 

3c3
<   "falsePositives": 408,
---
>   "falsePositives": 10407,
10c10
<     "933160": 1,
---
>     "933160": 10000,
15c15
<   "totalTime": 7355236987
---
>   "totalTime": 9614894260

@M4tteoP M4tteoP requested a review from fzipi November 4, 2024 23:55
@M4tteoP M4tteoP marked this pull request as ready for review November 4, 2024 23:55
M4tteoP
M4tteoP commented Nov 5, 2024
View reviewed changes
M4tteoP
M4tteoP commented Nov 7, 2024
View reviewed changes
fzipi
fzipi reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's run it for some days and circle back to see if we want slight changes on the output.

@fzipi
Copy link
Member

fzipi commented Nov 18, 2024

@M4tteoP Do you want to merge this one?

@fzipi fzipi mentioned this pull request Nov 18, 2024
Closed
@M4tteoP
Copy link
Member Author

M4tteoP commented Nov 18, 2024

Yes 💯

@M4tteoP M4tteoP added release:ignore Ignore for changelog release 🔧 ci/cd labels Nov 18, 2024
@M4tteoP M4tteoP added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 298b0a4 Nov 18, 2024
6 checks passed
@M4tteoP M4tteoP deleted the quantitative_diff branch November 18, 2024 09:18
@M4tteoP M4tteoP mentioned this pull request Nov 18, 2024
Open
@fzipi fzipi mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
release:ignore Ignore for changelog release 🔧 ci/cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M4tteoP @fzipi