Skip to content

fix: remove where, if, for and vol and resolve false positives (932380 PL1) #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix: remove where, if, for and vol and resolve false positives (932380 PL1) #3972

merged 2 commits into from
Jan 2, 2025

Conversation

franbuehler
Copy link
Contributor

This PR fixes #3930 by removing vol, if, where and for from rule 932380.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi requested a review from a team January 2, 2025 11:03
@franbuehler franbuehler added this pull request to the merge queue Jan 2, 2025
Merged via the queue into coreruleset:main with commit 161d897 Jan 2, 2025
6 checks passed
@franbuehler franbuehler deleted the fix-932380 branch January 2, 2025 20:45
@fzipi fzipi mentioned this pull request Jan 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positives with 932380 PL1 Remote Command Execution: Windows Command Injection
3 participants
@franbuehler @theseion @fzipi