fix: FP against pattern with = following at arbitrary position
#3963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change regular expression to not match any `=` - add FP and true positive tests Fixes coreruleset#3961
|
📊 Quantitative test results for language: |
fzipi
reviewed
Dec 29, 2024
fzipi
approved these changes
Dec 29, 2024
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 6, 2025
https://build.opensuse.org/request/show/1241296 by user pgajdos + anag+factory - package cleanup, coordinated with apache2-mod_security2 cleanup - version update to 4.10.0 * New features and detections - feat: block CVE-2023-5003 by @azurit in coreruleset/coreruleset#3955 - feat: prevent accessing PHP variables by @azurit in coreruleset/coreruleset#3965 * Other Changes - fix: FP against `pattern` with `=` following at arbitrary position by @theseion in coreruleset/coreruleset#3963 (forwarded request 1240839 from pgajdos)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=Fixes #3961