Skip to content

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Nov 24, 2024

what

  • adding comments from forks will fail unless we use the pull_request_target event

why

  • quantitative run needs to add comments to the PR

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi requested a review from a team November 24, 2024 14:02
M4tteoP
M4tteoP previously approved these changes Nov 24, 2024
Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi requested a review from theseion November 24, 2024 19:33
theseion
theseion previously approved these changes Nov 24, 2024
@fzipi fzipi added this pull request to the merge queue Nov 24, 2024
Merged via the queue into coreruleset:main with commit 404b005 Nov 24, 2024
5 checks passed
@fzipi fzipi deleted the fix/update-permissions-quant branch November 24, 2024 23:03
@fzipi fzipi added the release:ignore Ignore for changelog release label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:ignore Ignore for changelog release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants