Skip to content

Conversation

azurit
Copy link
Member

@azurit azurit commented Jun 20, 2024

As these rules are matching only against ARGS* variables, double URL decode can be removed immediately and without handling other related problems.

Partial fix for R9V-240531.

@fzipi fzipi requested a review from theseion June 20, 2024 13:57
@theseion
Copy link
Contributor

I think this is fine. However, I want to point out that t:urlDecodeUni will probably decode %FFuu in addition to the regular URL decoding. At least IIS might be vulnerable through such a payload.

@azurit
Copy link
Member Author

azurit commented Jun 20, 2024

Hm, you are right. Too bad modsec is not providing a separate transformation for %FFuu. We should discuss this in more detail.

@azurit azurit added the ⚠️ do not merge Additional work or discussion is needed despite passing tests label Jun 20, 2024
@theseion
Copy link
Contributor

The discussion around the custom encoding for IIS has come up repeatedly. I wonder whether we could just drop support for it entirely and create a plugin instead that takes care of it. Probably not that easy, because we have to duplicate a ton of rules in the plugin...

@dune73
Copy link
Member

dune73 commented Jun 21, 2024

That would be annoying, but I see the IIS problem. It's double problematic since we have zero insight into the number of IIS installations out there. It is super exotic, but we know it exists.

Can we create a separate issue for this problem and continue with this PR and the fixing of R9V-240531, apparently letting IIS users in the rain for a period of time.

@theseion
Copy link
Contributor

Sounds good to me.

@theseion
Copy link
Contributor

theseion commented Aug 5, 2024

I think this one's still not fully resolved, @azurit?

@theseion theseion reopened this Aug 5, 2024
@theseion theseion removed the Stale label Aug 5, 2024
@azurit
Copy link
Member Author

azurit commented Aug 5, 2024

@theseion No, it's not, thanks.

@azurit
Copy link
Member Author

azurit commented Sep 20, 2024

Can we create a separate issue for this problem and continue with this PR and the fixing of R9V-240531, apparently letting IIS users in the rain for a period of time.

@dune73 Can you be more specific? Should i create an issue describing that rules 921151, 932190, 942441, 942442 and 942460 are not doing* IIS specific decing of ARGS* data?

  • after this PR is merged

@dune73
Copy link
Member

dune73 commented Sep 23, 2024

@azurit Yes, I think we ought to create an issue that describes the remaining IIS problem after this PR is merged. Based on that issue we can then discuss a solution, a plugin approach, or drop support when decoding is involved or entirely because we lack insight into the user base and exposure and knowledge and IIS testing installations and what not.

@github-actions github-actions bot added the Stale label Oct 24, 2024
@azurit azurit removed ⚠️ do not merge Additional work or discussion is needed despite passing tests Stale labels Nov 2, 2024
@azurit azurit added this pull request to the merge queue Nov 2, 2024
Merged via the queue into coreruleset:main with commit db3fe8e Nov 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants