plugin/rewrite: Add EDNS0 Unset Action #7380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Simmons <215134900+dennis-ix@users.noreply.github.com>
Signed-off-by: Dennis Simmons <215134900+dennis-ix@users.noreply.github.com>
Signed-off-by: Dennis Simmons <215134900+dennis-ix@users.noreply.github.com>
|
@dennis-ix , great work on this one! 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7380 +/- ##
==========================================
+ Coverage 55.70% 59.99% +4.29%
==========================================
Files 224 273 +49
Lines 10016 17982 +7966
==========================================
+ Hits 5579 10789 +5210
- Misses 3978 6565 +2587
- Partials 459 628 +169 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dennis-ix , please address test failures. |
Signed-off-by: Dennis Simmons <215134900+dennis-ix@users.noreply.github.com>
|
Thanks @greenpau ! |
|
@dennis-ix , also please get coverage to 100% |
Signed-off-by: Dennis Simmons <215134900+dennis-ix@users.noreply.github.com>
|
@greenpau |
greenpau
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Adds an unset action to edns0 options in the rewrite plugin. This allows removing an edns0 option (local, nsid or subnet) from the request.
This can be useful when forwarding a request with internal data to an external server.
2. Which issues (if any) are related?
#7360
3. Which documentation changes (if any) need to be made?
Updated the rewrite plugin readme.
4. Does this introduce a backward incompatible change or deprecation?
No.