add args: startup_timeout for kubernetes plugin #7068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6f0928 to
d09598b
Compare
chrisohaver
reviewed
Jan 16, 2025
d09598b to
18355d8
Compare
zouyee
reviewed
Jan 20, 2025
|
This PR seems to have been blocked for a long time, do I need to add anything? @chrisohaver chir |
|
Hey @fzu-huang, could you rebase and resolve the conflicts? |
Signed-off-by: mangoyhuang <mangoyhuang@tencent.com>
18355d8 to
ff901a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7068 +/- ##
==========================================
+ Coverage 55.70% 59.91% +4.21%
==========================================
Files 224 273 +49
Lines 10016 17928 +7912
==========================================
+ Hits 5579 10742 +5163
- Misses 3978 6560 +2582
- Partials 459 626 +167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yongtang
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
In some scenarios this PR can speed up the startup of coredns
2. Which issues (if any) are related?
#7057
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?
A backward incompatible chang