Properly create hostname from IPv6 #7431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate valid hostname from IPv6 when the address ends with `::`. Signed-off-by: Guillaume Jacquet <guillaume.jacquet@gmail.com>
92d1f45 to
8bc38be
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7431 +/- ##
==========================================
+ Coverage 55.70% 59.77% +4.07%
==========================================
Files 224 273 +49
Lines 10016 18033 +8017
==========================================
+ Hits 5579 10780 +5201
- Misses 3978 6622 +2644
- Partials 459 631 +172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Hostname for an IPV6 address can be invalid if the address ends with
::.2. Which issues (if any) are related?
Fixes: #7430
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?
Generated hostname will be different if IP address ends with
::.