plugin/file: preserve case in SRV record names and targets per RFC 6763 #7402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e950c89 to
84dc450
Compare
|
@syedazeez337 will it make sense to add a test? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7402 +/- ##
==========================================
+ Coverage 55.70% 59.93% +4.23%
==========================================
Files 224 273 +49
Lines 10016 18015 +7999
==========================================
+ Hits 5579 10798 +5219
- Misses 3978 6586 +2608
- Partials 459 631 +172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
84dc450 to
4eeb77c
Compare
|
Hi @yongtang, I have added the test case for my code changes. Let me know if it rightly addresses the code guidelines of the organisation. Happy to contribute the changes needed. Thank you. |
4eeb77c to
586d04d
Compare
|
|
Signed-off-by: Syed Azeez <syedazeez337@gmail.com>
586d04d to
de6b23b
Compare
|
Hi @yongtang, I have resolved all the issues that were failing on the github Checks. I will wait for your review on the logic. Thank you. |
yongtang
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR ensures SRV record names and targets preserve their original case in responses, aligning with RFC 6763 §4.1.1, which requires that service instance names be treated as user-friendly Unicode text and must retain casing and formatting.
What Changed
Insert()(e.g.samba.home.arpa.)less()inplugin/file/tree/less.gonow compares labels case-insensitivelydigQuery:
dig @127.0.0.1 -p 53 SRV "Home\\032Media._smb._tcp.home.arpa."Expected response:
Why this is needed
Although DNS is case-insensitive, [RFC 6763](https://datatracker.ietf.org/doc/html/rfc6763#section-4.1.1) mandates that SRV record names used in service discovery retain original case and formatting, especially for mDNS, Bonjour, and DNS-SD clients.
Prior to this fix, CoreDNS returned lowercased instance names, breaking spec-compliant discovery clients.
Limitations
This PR does not preserve the casing of the query name, as it is already normalized (lowercased) by CoreDNS or
miekg/dnsbefore plugin processing. This fix ensures the record data (response) complies with the spec.Related
Fixes #7237