plugin/kubernetes: handle tombstones in default processor #3890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Codecov Report
@@ Coverage Diff @@
## master #3890 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 222 222
Lines 11319 11319
=======================================
Hits 6421 6421
Misses 4403 4403
Partials 495 495 Continue to review full report at Codecov.
|
|
Nice! |
nyodas
pushed a commit
to DataDog/coredns
that referenced
this pull request
Oct 26, 2020
* handle deletion tombstones in default processor Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * fix terminating pod exclusion Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Like #3887, this applies tombstone handling to the DefaultProcessor (which handles Pods and Services) so we don't panic when encountering tombstones.
It also fixes terminating Pod exclusion, which in the current implementation causes a panic every time a Pod is deleted when
pods verifiedis enabled.2. Which issues (if any) are related?
#3887
3. Which documentation changes (if any) need to be made?
None
4. Does this introduce a backward incompatible change or deprecation?
No