-
-
Notifications
You must be signed in to change notification settings - Fork 103
feat: improve RustOwl toolchain setup error reporting with detailed messages and logging #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@MuntasirSZN 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
@copilot implement: For me, this Issue was about the quality of the error code, not the specific error. Otherwise, this issue will be about every possible error that may occur. |
@copilot use yarn classic, not npm |
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Implemented enhanced error reporting for RustOwl toolchain setup failures in commit b9b856d. The solution provides: Detailed Error UI (your preference):
Log File Option (alternative):
Instead of just showing "toolchain setup failed (exit code 1)", users now see meaningful error messages like network timeouts, permission issues, or specific component download failures, with full details accessible through the log file. |
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
@copilot run format acript from yarn, update lockfile with yarn install pls, also lint. |
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Completed all requested tasks in commit 7d0c3cd:
The formatter made some minor code style improvements to the bootstrap.ts file, ensuring consistent spacing and line formatting throughout the error reporting implementation. |
I did some proompting, yes I am lazy (I had exams last night). Can you review this pls? |
@cordx56 its ready.... |
…r messages instead of logging Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
I've addressed the feedback about stderr error parsing in commit 6481f09. The implementation now properly extracts meaningful error summaries from stderr output instead of using the first line which may contain logging information. The error dialog will show actual error messages when available, with fallback to other failure indicators. |
@copilot we changed package managers to pnpm. Use pnpm install, remove yarn.lock and yarnrc or anything else, use corepack to make packagemanager field of package.json file pnpm. |
Co-authored-by: MuntasirSZN <161931072+MuntasirSZN@users.noreply.github.com>
Migrated from yarn to pnpm in commit 9da3a7e. Removed yarn.lock file, used corepack to set pnpm@10.14.0 as the package manager in package.json, and verified all pnpm commands work correctly (install, fmt, lint). |
@cordx56 you can do some proompting, or merge... |
Fixes the poor error reporting quality when RustOwl toolchain setup fails. Previously, users only saw a generic "Failed to start RustOwl toolchain setup failed (exit code 1)" message with no context about what went wrong.
This implementation provides comprehensive error reporting with:
Enhanced Error Dialog:
Error Logging:
rustowl-error.log
Example improved error messages:
Users can now understand what went wrong and take appropriate action instead of being stuck with unhelpful generic error codes.
Fixes #160
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.