-
-
Notifications
You must be signed in to change notification settings - Fork 293
Audio and onComplete... third time's a charm? #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd buffer and assignment logic Next up, prepare details from graphics.defineEffect()
…from Program Slight redesign of TimeTransform with caching (to synchronize multiple invocations with a frame) and slightly less heavyweight call site
Err, was calling Modulo for sine method, heh That said, time transform seems to work in basic test
Fixed error detection for positive number time transform inputs Relaxed amplitude positivity requirement
Maintenance Revert Test
My mistake adding back changes made
This reverts commit 0b5e1e9.
Notes for Delete(), in case we want a thread-safe version later
…, but aren't used in production) GetOrCreate() removed; the ones not used by event listeners are Create()'d up front Slight change of PROFILING_BEGIN() macro for new usage Simulator run variable is gone now
… (or nil ref, when not needed) and no ref means a channel is empty (for purposes of stopping) Avoids lots of new and delete More importantly, one notifier with lifetime outside the thread (no unguarded updating of reference counts) No need for loop to delete them (with potential race) since will go away with Lua Array of atomic flags to go with channel-to-callbacks, should avoid remaining race possibilities
…listener, rather than when event name first appeared globally Removed ShortName (since it also blew up the size of some structures) and enforcing that profiling-related string lifetimes are static or held in Lua Replaced with Payload that can take a string or a pointer (table or function) Also has an option for owned strings, but probably iffy (or could be something else instead) Due to that, able to avoid some allocations in getTimings() Also added other possiblities there when time is false (as with sublists), using a @ at start to indicate keyword
Shchvova
approved these changes
Jan 7, 2024
Shchvova
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per some discussion in #help-and-support, it seems there was a misfire on my last submission. I had a single notifier for the audio messages, but the way tasks work was built on having a Lua reference paired to each notifier, or vice versa. I was not doing this, and in fact only used the callback as a dummy to get the event accepted... so nothing was firing.☹️
(This was a late change and I was still testing for
playSound()
stability, so missed that my printouts had disappeared.)The task themselves may now take a Lua reference, and the notifier will prefer that, if present.
With this I'm getting
onComplete
again.