Fix: always reset static profiling IDs #660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd buffer and assignment logic Next up, prepare details from graphics.defineEffect()
…from Program Slight redesign of TimeTransform with caching (to synchronize multiple invocations with a frame) and slightly less heavyweight call site
Err, was calling Modulo for sine method, heh That said, time transform seems to work in basic test
Fixed error detection for positive number time transform inputs Relaxed amplitude positivity requirement
Maintenance Revert Test
My mistake adding back changes made
This reverts commit 0b5e1e9.
…erationID in Runtime Profiling begin macro now takes Runtime argument No simulator-only distinction for same
|
After looking into an error that arose with build 3701 I see that Mac's relaunch mechanics are hard to square with In light of that Mac behavior I might have to reconsider the aforementioned generation ID as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @naveen-pcs in #645, there was a new crash with this sort of error in 3701:
[split_config.arm64_v8a.apk!libcorona.so] Rtt_Profiling.cpp - Rtt::Profiling::EntryRAII::EntryRAII(Rtt::ProfilingState&, int&, char const*)This seemed to be consistent with a profile entry not being allocated, as if the ID were invalid in that part of the code. This was odd, since when the ID was
Noneit just adds a slot to the array, the code seems to generally just work otherwise, and the device reports didn't seem to indicate any memory problems.By a total fluke—while trying to figure out something else—I stumbled on this comment, and in particular niko20's point here.
That sounds right on target. These
staticIDs are new with the recent changes, and if they survived a new launch they would refer to bogus spots in the profiling list.I had logic to update one "simulator run" value in the profiling state, if it was in simulator, that would make IDs
Noneon first use, since the simulator run would differ from a "master" value. I've now changed it to just do that unconditionally.It actually looks like the "master" value would be more generally useful (for instance in some audio fixes, rather than comparing pointers across threads), so I moved it out of the profiling state into
Runtime, asGetGenerationID().