Core/Android: add sanity check #655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes come from analyzing the OOM crash stack, enhancing some of the checks.
These changed stack contents in cases where an error had already occurred.
Regarding
Data.Set()
, it is envisioned that in the OOM case, fLength retains a non-zero value even if fStorage is empty. It is good practice to perform aData.Get()
check before using it.Of course, there's also an Android
build.gradle.kts
issue where switchingcoronaSrcDir
causes the previous project'sresource.car
content to be incorrectly retained as the gradle script uses theCoronaBuilder car
command to do the append action.This time I modified the file header, replaced Corona with Solar2D and added declarations.
Thanks.