Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains where
Fix typo
Some typo fixes.
Fix Gradle task not recognize file changes
Fix when using the 'Run' button in Android Studio to re-run with a changed Lua project file, the Gradle task does not recognize the changes and incorrectly marks mergeDebugAssets as
UP-TO-DATE
, this cause App remain unchange.This is a temporary solution to facilitate debugging of Android applications by Solar2D engine maintainers, and Gradle tasks should be reorganized in the future.
FileService IO buffer size changed
Adjust buffer sizes that are more friendly to memory paging and I/O throughput. 64KB size vs. the original 1KB, using FileService#getBytesFromFile() reading 100MB (unflatten) of
resource.car
is at least a 10% improvement on the Pixel 7 and 30% on the Galaxy S7 edge.Additionally, in the future, it will be necessary to change the way Android reads Lua code packages (
resource.car
) to the same mmap method as Apple and Linux platforms, in order to save a copy of runtime memory of the size ofresource.car
after it is unflatten.Remove redundant splash resource check
In an ANR problem we encountered, we found that CoronaActivity#showCoronaSplashScreen() initializes the FileService to do the caching of the relative location of the file to improve the efficiency of the subsequent reading of the resource, this IO operation is performed in the main thread resulting in an ANR, and it is not necessary to retrieve the existence of the resource from the FileService while checking the resource ID, choosing one or the other is sufficient.
See getIdentifier().
loadExpansionFiles even when storage read-only
.
Introduced reportFullyDrawn()
See reportFullyDrawn() and TTFD, users can call
system.request("reportFullyDrawn")
to report Fully Drawn.Feel free to raise the discussion.
Thanks.