Some small issues in canvas texture setup #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…involve origins in calculation pixelWidth and pixelHeight ignored unless both were set Allow pixelWidth to be used as width if the latter is absent (ditto height)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug described here:
The two-argument
ContentToScreen()is used for convenience when calculating the pixel dimensions of the canvas, since the coordinates would go unused. Unfortunately, that's meant for coordinates, and so it drags any non-0 screen origins into the calculation.(Snapshots also do this.)
A more minor issue: if
pixelWidthorpixelHeightwas provided as a canvas option, but not both, they were ignored.This also adds a (backward-compatible) shorthand for setting
widthandpixelWidthto the same value (ditto height): ifpixelWidthis provided but notwidth, it will be used for both.