Skip to content

refactor(all): use errors.New to replace fmt.Errorf with no parameters #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2024
Merged

refactor(all): use errors.New to replace fmt.Errorf with no parameters #1483

merged 2 commits into from
Jul 24, 2024

Conversation

yukionfire
Copy link
Contributor

No description provided.

@yukionfire yukionfire requested a review from a team July 18, 2024 03:13
reecepbcups
reecepbcups approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@reecepbcups reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are completely identical. Soft approving, but will allow someone else to decide if it is worth it or not. tbh I do not see benefit as most use fmt.Errorf anyways 🤷

@yukionfire yukionfire changed the title all: use errors.New to replace fmt.Errorf with no parameters refactor(all): use errors.New to replace fmt.Errorf with no parameters Jul 18, 2024
@reecepbcups reecepbcups enabled auto-merge (squash) July 24, 2024 02:02
@reecepbcups reecepbcups merged commit 4ed2615 into cosmos:main Jul 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@reecepbcups reecepbcups reecepbcups approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukionfire @reecepbcups