fix: avoid counterparty recv packet message get removed before open channel #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hannel this change was related to cosmos@8b7184b
jtieri
approved these changes
May 6, 2024
Yes, retry once would be good enough for this edge case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relay packet message happens right before new channel get created, for more info:
2024-05-01T01:36:49.868214Z info Successfully created new channel {"chain_name": "cronos_777-1", "chain_id": "cronos_777-1", "channel_id": "channel-2", "connection_id": "connection-0", "port_id": "icacontroller-crc1q04jewhxw4xxu3vlg3rc85240h9q7ns6hglz0g"}
2024-05-01T01:36:52.722142Z info Successful transaction {"provider_type": "cosmos", "chain_id": "chainmain-1", "gas_used": 161557, "fees": "196281000000basecro", "fee_payer": "cro1u08u5dvtnpmlpdq333uj9tcj75yceggszxpnsy", "height": 57, "msg_types": ["/ibc.core.client.v1.MsgUpdateClient", "/ibc.core.channel.v1.MsgChannelOpenConfirm"], "tx_hash": "46663D951CA2738EC796451679400C351D93AD3B73F22778654CA5301EA39F09"}
2024-05-01T01:36:52.869073Z warn Refusing to relay packet message because channel is not open {"path_name": "chainmain-cronos", "chain_id": "chainmain-1", "client_id": "07-tendermint-0", "event_type": "recv_packet", "sequence": 1, "channel_id": "channel-2", "port_id": "icahost", "counterparty_channel_id": "channel-2", "counterparty_port_id": "icacontroller-crc1q04jewhxw4xxu3vlg3rc85240h9q7ns6hglz0g"}
2024-05-01T01:36:52.869222Z info Successfully created new channel {"chain_name": "chainmain-1", "chain_id": "chainmain-1", "channel_id": "channel-2", "connection_id": "connection-0", "port_id": "icahost"}