Skip to content

Ensure that ✘ is displayed for clients if they are expired #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2023
Merged

Ensure that ✘ is displayed for clients if they are expired #1352

merged 3 commits into from
Dec 5, 2023

Conversation

vimystic
Copy link
Contributor

@vimystic vimystic commented Dec 4, 2023 •
edited
Loading

Using existing methods in query.go to achieve required fix.
Fixes #1241

@vimystic vimystic marked this pull request as ready for review December 4, 2023 16:12
@vimystic vimystic mentioned this pull request Dec 4, 2023
Closed
jtieri
jtieri approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had the one small nit but otherwise this looks good! i'll just approve now so you are not blocked on me

@vimystic vimystic merged commit 1c18c2b into cosmos:main Dec 5, 2023
@vimystic vimystic deleted the vimystic/rly_paths_list_correction branch December 5, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@boojamya boojamya Awaiting requested review from boojamya

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

1 more reviewer

@jtieri jtieri jtieri approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rly paths list shows ✔ when client is expired.
2 participants
@vimystic @jtieri