test: update block proposer in testing (backport #7430) #7454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce two following changes to the `commitBlock` method in testing: * increment the proposer priority of validators * update the proposer address in the current header * fix linter (cherry picked from commit 64f33e0)
|
colin-axner
approved these changes
Oct 14, 2024
DimitrisJim
approved these changes
Oct 14, 2024
damiannolan
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, test chains carry the same block proposer for every block. This can lead to a situation where the block proposer isn't part of the validator set, such as after being jailed. This can cause the validation of validator sets to fail in
CometBFT v0.38.12, see ValidateBasic.This PR addresses the issue by incrementing the validator proposer priority in test chains, ensuring that the block proposer is updated in line with changes to the validator set.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.This is an automatic backport of pull request #7430 done by [Mergify](https://mergify.com).