-
Notifications
You must be signed in to change notification settings - Fork 716
Closed as not planned
Closed as not planned
Copy link
Labels
30-middlewarechange: api breakingIssues or PRs that break Go API (need to be release in a new major version)Issues or PRs that break Go API (need to be release in a new major version)type: refactorArchitecture, code or CI improvements that may or may not tackle technical debt.Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Description
Improvement for IBC middleware pipelining as suggested by @damiannolan:
- Remove the
ics4Wrapper
field from 29-fee keeper and 27-controller keeper. - Add extra
next
field of typeporttypes.ICS4Wrapper
to 29-feeIBCMiddleware
and 27-controllerIBCMiddleware
, and anext
argument to the correspondingNewIBCMiddleware
constructor functions. We would have something like:
func NewIBCMiddleware(app porttypes.IBCModule, k keeper.Keeper, next porttypes.ICS4Wrapper) IBCMiddleware {
return IBCMiddleware{
app: app,
keeper: k,
next: next,
}
}
- Replace in the implementation of the ICS4 wrapper interface in 29-fee and 27-controller the usage of
keeper
fornext
.
damiannolanGNaD13
Metadata
Metadata
Assignees
Labels
30-middlewarechange: api breakingIssues or PRs that break Go API (need to be release in a new major version)Issues or PRs that break Go API (need to be release in a new major version)type: refactorArchitecture, code or CI improvements that may or may not tackle technical debt.Architecture, code or CI improvements that may or may not tackle technical debt.