Skip to content

refactor: api consitency #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2023
Merged

refactor: api consitency #817

merged 2 commits into from
Aug 11, 2023

Conversation

julienrbrt
Copy link
Contributor

@julienrbrt julienrbrt commented Aug 11, 2023 •
edited
Loading

API consistency for #815

@julienrbrt julienrbrt marked this pull request as ready for review August 11, 2023 15:27
@julienrbrt julienrbrt requested review from a team and cool-develope August 11, 2023 15:27
cool-develope
cool-develope approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@cool-develope cool-develope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the updates!

@julienrbrt julienrbrt merged commit f85aac1 into marko/make_batcher_configurable Aug 11, 2023
@julienrbrt julienrbrt deleted the julien/api-consistency branch August 11, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@cool-develope cool-develope cool-develope approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @cool-develope