fix: traverseNodes unexpected behaviour
#718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traverseNodes unexpected behaviourtraverseNodes unexpected behaviour
|
@catShaark , thanks for catching it, it seems like we need to refactor the |
|
should I close this now |
or you can modify it |
|
ohh, I'll modify this |
|
adding more cases to the test |
cool-develope
approved these changes
Apr 3, 2023
|
@catShaark can we get a changelog here then we can merge |
|
Yess |
|
@tac0turtle, changelog added |
tac0turtle
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traverseNodes, we iterate through every nodes (including root nodes) and unmarshal the marshalled node's value viaMakeNode.MakeNodeis made only for unmarshaling a marshalled node's value, so if a marshalled node's value is actually a node's key like described above, it'll handle incorrectly.traverseNodeswe check if the marshalled node's value is indeed a root node's key so that we can ignore it