Fix CSIu encoding of shift modifier produced characters #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duced characters When `CSI > 1 u` was used to enter CSI u mode with DisambiguateEscapeCodes flag set, then (e.g. on German keyboard layout), a double quote is produced with Shift + 2, which generate the double quotes: " This should not needed to be disambiguated (unless explicitly requested) Signed-off-by: Christian Parpart <christian@parpart.family>
4162cfa to
7ee61cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
CSI > 1 uwas used to enter CSI u mode with DisambiguateEscapeCodes flag set, then (e.g. on German keyboard layout), a double quote is produced with Shift + 2, which generate the double quotes:"This should not needed to be disambiguated (unless explicitly requested)
Closes #1373