Skip to content

Fix window resize events not respecting content scale #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 18, 2023
Merged

Fix window resize events not respecting content scale #1365

merged 5 commits into from
Dec 18, 2023
+62 −30

Conversation

christianparpart
Copy link
Member

@christianparpart christianparpart commented Dec 18, 2023 •
edited
Loading

this is mostly affecting HiDPI screens, anything with a non-standard DPI setting.

no changelog entry needed, because it was introduced with the QML rework

Closes #1299.

@github-actions github-actions bot added VT: Backend Virtual Terminal Backend (libterminal API) frontend Contour Terminal Emulator (GUI frontend) labels Dec 18, 2023
@christianparpart christianparpart mentioned this pull request Dec 18, 2023
Closed
@christianparpart christianparpart added the no changelog Tells the CI to not require a changelog entry label Dec 18, 2023
@christianparpart
Rework logging wrt window resizing a bit
ddec524 
Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart
[contour] TerminalDisplay: cleanup resizeWindow(Width, Height)
5759236 
Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart
[cnotour] TerminalSession: Fix resize on HiDPI screens
6cf458b 
Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart
[contour] TerminalSession: Improve logging output a tiny bit
f15fe21 
Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart
[TerminalDisplay] Refactor contentScale() for better maintainability
789c842 
And have the log message printed only upon value change.

Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart mentioned this pull request Dec 18, 2023
Merged
Yaraslaut
Yaraslaut approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, hope we can release now

@christianparpart christianparpart merged commit cf434ea into master Dec 18, 2023
@christianparpart christianparpart deleted the fix/hidpi branch December 18, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yaraslaut Yaraslaut Yaraslaut approved these changes

Assignees
No one assigned
Labels
frontend Contour Terminal Emulator (GUI frontend) no changelog Tells the CI to not require a changelog entry VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DPI adjustment at least sometimes broken
2 participants
@christianparpart @Yaraslaut