Fixes setting window class (app_id) on Wayland
#1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ce2d46 to
2f12910
Compare
uspasojevic96
requested changes
Nov 16, 2023
ef6a592 to
83b3f9f
Compare
On Wayland, there's no such thing as WM_CLASS (X11), but a user can use the `app_id` to identify and group Application windows. However, Qt sets that not via QCoreApplication::setApplicationName but rather uses QCoreApplication::setOrganizationDomain's information in reverse name order. Signed-off-by: Christian Parpart <christian@parpart.family>
83b3f9f to
6d9133d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Wayland, there's no such thing as WM_CLASS (X11), but a user can use the
app_idto identify and group Application windows. However, Qt sets that not via QCoreApplication::setApplicationName but rather uses QCoreApplication::setOrganizationDomain's information in reverse name order.Closes #1336.