Fix some Qt/OpenGL related problems #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af1e03e to
5fa00be
Compare
Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
…t it will be deleted automatically by the QML's GC This avoids random (but orderly) Contour instance terminations, just because Qt assumed the TerminalSession object would not be needed anymore. Signed-off-by: Christian Parpart <christian@parpart.family>
5fa00be to
dd0dbfe
Compare
dd0dbfe to
8b47cf6
Compare
Interestingly, by moving to QOpenGLTexture. Signed-off-by: Christian Parpart <christian@parpart.family>
8b47cf6 to
fc98ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1309, #1312